Skip to content

Working indicator for queries - #583

Merged
OmkarPh merged 1 commit into
v4.0-react-typescriptfrom
feature/workingIndicator
Jul 17, 2023
Merged

OmkarPh merged 1 commit into
v4.0-react-typescriptfrom
feature/workingIndicator

Conversation

@OmkarPh

@OmkarPh OmkarPh commented Jun 12, 2023 •

Copy link
Copy Markdown
Collaborator

Fixes #552

@OmkarPh
OmkarPh force-pushed the feature/workingIndicator branch from 4e6c0a6 to 221c382 Compare June 19, 2023 16:13
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
OmkarPh force-pushed the feature/workingIndicator branch from 221c382 to 52839e6 Compare June 19, 2023 17:22

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OmkarPh, the processing icon with the gear looks perfect and shows up in the right place.
Starts showing up from ~5-10 MB scans and works properly for bigger several hundred MB scans too, without freezing.

@OmkarPh

OmkarPh commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks for the review, merging 🚀

@OmkarPh
OmkarPh merged commit c8b8332 into v4.0-react-typescript Jul 17, 2023
@OmkarPh OmkarPh linked an issue Jul 19, 2023 that may be closed by this pull request
@AyanSinhaMahapatra
AyanSinhaMahapatra deleted the feature/workingIndicator branch October 25, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Worker thread support for "working" icon indicator

2 participants