[hesa]

Fixes #3934

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁
• Updated documentation pages (if applicable)
• Updated CHANGELOG.rst (if applicable)

[AyanSinhaMahapatra]

Thanks++ @hesa see comments for your consideration wrt.:

• deprecating rules vs changing the text
• using required_phrases vs minimum_coverage

Also lots of text failures which are related to your changes and we need to update test expectations there.
For example:
SCANCODE_REGEN_TEST_FIXTURES=yes pytest -vvs tests/packagedcode/test_debian_copyright.py::TestDebianCopyrightLicenseDetection::test_debian_parse_copyright_file_detailed_main_g_gnupg2_stable_copyright --test-suite=validate
All of the related test failures seem to be for debian copyright files where we need to update expectations.

[AyanSinhaMahapatra]

We cannot change rule text content, instead we should deprecate a rule and create new rules as required as these are useful reference for detections.

[AyanSinhaMahapatra]

Otherwise folks using an older version and getting a match with this rule would be confused about the matched text. We ourselves also use this for diff btw

[AyanSinhaMahapatra]

Not sure if this a good idea to keep "author" in required phrases, as this could change, though I have not found any cases where other authors are used. Setting a high minimum_coverage is another option, when there aren't great required phrases.