Skip to content

Validate value of requires nodes in the canonical features list #64

Closed

Description

@QuintinWillison

If the feature node passed does not exist then the build must fail.

Follows on from the work done in #63, in that case we would be checking that Debugging: Error Information exists in the tree.

It would also make sense to add other logical checks like ensuring that a feature node doesn't indicate that it requires one of its parent nodes, as that's implicit.

┆Issue is synchronized with this Jira Uncategorised by Unito

Activity

  1. QuintinWillison commented on Sep 30, 2022

    @QuintinWillison
    ContributorAuthor

    Also, REST and Realtime are pivotal/foundational enough root nodes that the following should also be policed by the checks:

    • should only require both the REST and Realtime features if both of them must be present in the SDK for the feature to work at all, in other words:
      • 🟢 needs both: if it requires both REST and Realtime to be viable, then it should include them both in its requires property
      • 🔴 needs one, the other, or both: if it requires either REST or Realtime to be viable, then it must not include either of them in its requires property
      • 🟢 needs just REST: if it requires REST but does not require or otherwise relate to Realtime, then it should include REST in its requires property
      • 🟢 needs just Realtime: if it requires Realtime but does not require or otherwise relate to REST, then it should include Realtime in its requires property
  2. added
    buildRelates to the tooling and/or scripts that render the HTML microsite published from here.
    on Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildRelates to the tooling and/or scripts that render the HTML microsite published from here.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions