You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Validate value of requires nodes in the canonical features list #64
If the feature node passed does not exist then the build must fail.
Follows on from the work done in #63, in that case we would be checking that Debugging: Error Information exists in the tree.
It would also make sense to add other logical checks like ensuring that a feature node doesn't indicate that it requires one of its parent nodes, as that's implicit.
Also, REST and Realtime are pivotal/foundational enough root nodes that the following should also be policed by the checks:
should only require both the REST and Realtime features if both of them must be present in the SDK for the feature to work at all, in other words:
🟢 needs both: if it requires bothRESTandRealtime to be viable, then it should include them both in its requires property
🔴 needs one, the other, or both: if it requires eitherRESTorRealtime to be viable, then it must not include either of them in its requires property
🟢 needs just REST: if it requires REST but does not require or otherwise relate to Realtime, then it should include REST in its requires property
🟢 needs just Realtime: if it requires Realtime but does not require or otherwise relate to REST, then it should include Realtime in its requires property
Activity
QuintinWillison commentedon Sep 30, 2022
Also,
RESTandRealtimeare pivotal/foundational enough root nodes that the following should also be policed by the checks:RESTandRealtimefeatures if both of them must be present in the SDK for the feature to work at all, in other words:RESTandRealtimeto be viable, then it should include them both in itsrequirespropertyRESTorRealtimeto be viable, then it must not include either of them in itsrequirespropertyRESTbut does not require or otherwise relate toRealtime, then it should includeRESTin itsrequirespropertyRealtimebut does not require or otherwise relate toREST, then it should includeRealtimein itsrequiresproperty