You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on implementation/version-2 I noticed many deprecated methods, lousy formatting, and other warnings.
Running lint revealed 133 errors, 2.297 warnings, 56 week-warnings, and 1.393 typos. While a lot of them are not valid warnings a lot of them are and should be addressed.
We should run code formatting and optimize imports so everything is tidy.
Work on this issue will need to include adding these lint checks to CI in our check workflow. I understand from @qsdigor that the command he's using locally (which we don't currently run in CI) is ./gradlew lint or in IntelliJ "toolbar -> code -> inspect code -> whole project -> ok".
Activity
sync-by-unito commentedon Oct 24, 2022
➤ Automation for Jira commented:
The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2866
QuintinWillison commentedon Oct 31, 2022
Work on this issue will need to include adding these lint checks to CI in our check workflow. I understand from @qsdigor that the command he's using locally (which we don't currently run in CI) is
./gradlew lintor in IntelliJ "toolbar -> code -> inspect code -> whole project -> ok".