Skip to content

Code cleanup and warning checkup #848

Open

Description

@qsdigor

While working on implementation/version-2 I noticed many deprecated methods, lousy formatting, and other warnings.

Running lint revealed 133 errors, 2.297 warnings, 56 week-warnings, and 1.393 typos. While a lot of them are not valid warnings a lot of them are and should be addressed.

We should run code formatting and optimize imports so everything is tidy.

┆Issue is synchronized with this Jira Task by Unito

Activity

  1. added
    code-qualityAffects the developer experience when working in our codebase.
    on Oct 24, 2022
  2. sync-by-unito commented on Oct 24, 2022

    @sync-by-unito

    ➤ Automation for Jira commented:

    The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2866

  3. added this to the 2.0.0 milestone on Oct 31, 2022
  4. QuintinWillison commented on Oct 31, 2022

    @QuintinWillison
    Contributor

    Work on this issue will need to include adding these lint checks to CI in our check workflow. I understand from @qsdigor that the command he's using locally (which we don't currently run in CI) is ./gradlew lint or in IntelliJ "toolbar -> code -> inspect code -> whole project -> ok".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityAffects the developer experience when working in our codebase.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions