Skip to content

Cleanup deprecated methods #831

Open

Description

@qsdigor

We need to remove some of the deprecated methods. Targeting version 2.0.0 is the best time to do so as it is a major change.
There are not many of them and all have replacement methods.

Deprecated since 08/01/2017
public static TokenRequest fromJSON(JsonObject json)

|----|
| replacement |

public static TokenDetails fromJsonElement(JsonObject json)

Deprecated since 30/10/2015
public static TokenDetails fromJSON(JsonObject json)

|----|
| replacement |

public static TokenDetails fromJson(String json)

Deprecated since 06/07/2022
public TokenDetails renew()

|----|
| replacement |

public void renewAuth(RenewAuthResult result)

Deprecated since 03/02/2022
public ChannelCipher getCipher()

|----|
| replacement |

public synchronized ChannelCipherSet getCipherSet()

Deprecated since 01/11/2019
public static ChannelOptions fromCipherKey(byte[ ] key)

|----|
| replacement |

public static ChannelOptions withCipherKey(byte[ ] key)

Deprecated since 01/11/2019
public static ChannelOptions fromCipherKey(String base64Key)

|----|
| replacement |

public static ChannelOptions withCipherKey(String base64Key)

Deprecated since 03/02/2022
public interface ChannelCipher

|----|
| replacement |

public interface ChannelCipherSet

Deprecated since 16/01/2017
public void emit(ConnectionState state, ConnectionStateChange stateChange)

Deprecated since 16/01/2017
public void on(ConnectionState state, ConnectionStateListener listener)

Deprecated since 16/01/2017
public void once(ConnectionState state, ConnectionStateListener listener)

Deprecated since 16/01/2017
public TokenDetails authorise(TokenParams params, AuthOptions options)

|----|
| replacement |

public TokenDetails authorize(TokenParams params, AuthOptions options)

Deprecated since 27/10/2020
public boolean fallbackHostsUseDefault

Tests:
Deprecated since 01/11/2019
public void channel_options_from_cipher_key()

┆Issue is synchronized with this Jira Task by Unito

Activity

  1. self-assigned this
    on Sep 8, 2022
  2. added this to the 2.0.0 milestone on Sep 8, 2022
  3. deanna-seta commented on Jan 24, 2023

    @deanna-seta

    The corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breakingBackwards incompatible changes made to the public API.code-qualityAffects the developer experience when working in our codebase.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions