Implement backoff and jitter timeout by spec RTB1 - #852
Merged
Conversation
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 15, 2022 14:49
Inactive
Add test for TimerUtil range test
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 16, 2022 13:54
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 16, 2022 13:57
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 17, 2022 09:40
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 17, 2022 15:38
Inactive
Improve test for TimerUtilsTest
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 18, 2022 16:15
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 21, 2022 09:56
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 21, 2022 10:00
Inactive
qsdigor
requested review from
KacperKluka,
QuintinWillison,
ikbalkaya and
owenpearson
November 21, 2022 11:52
qsdigor
marked this pull request as ready for review
November 21, 2022 11:55
owenpearson
requested changes
Nov 21, 2022
owenpearson
left a comment
owenpearson
left a comment
Member
There was a problem hiding this comment.
The implementation looks correct to me, I've left a couple of minor comments. I would also strongly consider using Random with a seed for testing if possible, that will give you a much cleaner and more predictable way of testing this.
github-actions
Bot
temporarily deployed
to
staging/pull/852/javadoc
November 21, 2022 13:03
Inactive
QuintinWillison
suggested changes
Nov 22, 2022
ikbalkaya
approved these changes
Nov 23, 2022
ikbalkaya
left a comment
ikbalkaya
left a comment
Contributor
There was a problem hiding this comment.
I have not carefully checked spec against this change and I just generally went through code which looks good to me
QuintinWillison
approved these changes
Nov 23, 2022
sacOO7
reviewed
Jun 14, 2023
| for (int i = 0; i < retryValues.size(); i++) { | ||
| long retryTime = retryValues.get(i); | ||
| long higherRange = disconnectedRetryTimeout + Math.min(i, 3) * 50L; | ||
| double lowerRange = 0.6 * disconnectedRetryTimeout + Math.min(i, 3) * 50L; |
Contributor
There was a problem hiding this comment.
change to
double lowerRange = 0.8 * (disconnectedRetryTimeout + Math.min(i, 3) * 50L);
sacOO7
reviewed
Jun 14, 2023
| int defaultTimerMs = 150; | ||
| int timerMs = TimerUtil.getRetryTime(defaultTimerMs, i); | ||
| long higherRange = defaultTimerMs + Math.min(i, 3) * 50L; | ||
| double lowerRange = 0.3 * defaultTimerMs + Math.min(i, 3) * 50L; |
Contributor
There was a problem hiding this comment.
change to
double lowerRange = 0.8 * (defaultTimerMs + Math.min(i, 3) * 50L);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.