chore: remove dead legacy error-string mappings in form-error.ts - #37
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Removes 22 lines of dead code from
packages/console/app/src/lib/form-error.ts:mapobject (e.g."Invalid plan","Workspace ID is required","Email is required","Model is required") that mapped pre-i18n raw error strings to i18n keys. No code in the monorepo produces any of these raw strings anymore — they were superseded byformError.*keys during the i18n migration, so the lookups were unreachable.localizeErrormatching/^Reload amount must be at least \$(\d+)$/and/^Balance trigger must be at least \$(\d+)$/. The producers of those strings were replaced byformErrorReloadAmountMin/formErrorReloadTriggerMin(which emit theerror.reloadAmountMin:<amount>prefix format handled by the earlierstartsWithbranches), so the regex branches were unreachable.The payment-related
mapentries ("workspace.reload.error.paymentFailed","Payment failed","Payment failed.") are kept —billing.tsandstripe/webhook.tsstill feed those strings intolocalizeErrorvia thereloadErrorDB column.How did you verify your code works?
npx tsgo --noEmitinpackages/console/app— passes with no errors.formError,formErrorReloadAmountMin,formErrorReloadTriggerMin,localizeError) are unchanged and still resolve to their 11+ production callers.Screenshots / recordings
N/A — no UI change.
Checklist
History
Dead Code PRs can be configured here.