chore: remove dead Ukrainian i18n override keys - #36
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Removes 38 Ukrainian translation override keys from
packages/console/app/src/i18n/uk.tsthat have no live production consumer (anyt("...")call-site) inpackages/console/app. Each removed key also exists inen.ts, so the...enspread continues to supply an English fallback at runtime — no behavior change, anduk.tshas nosatisfies Dictconstraint, so there is no type error.The dead keys fall into groups whose consuming UI was removed in earlier commits:
go.testimonials.*(21) — the/gotestimonials section was removed.go.privacy.*(5) — the/goprivacy section was removed.go.graph.free/freePill/aria(3) — the Go usage graph was redesigned; onlygo.graph.go/label/usageLimitsremain in use.go.cta.start(1) — replaced by thego.cta.template/text/price/promotemplate.go.faq.a5.beforeExceptions/exceptionsLink(2) — the Go FAQ-5 answer was rewritten to usego.faq.a5.body.common.contactUs(1) — orphaned by the Go privacy-section removal (the distinctworkspace.billing.contactUskey is still live).download.hero.subtitle(1) — the download hero subtitle was removed fromroutes/download.workspace.keys.table.lastUsed(1) — the "last used" column was removed from the API keys table.nav.changelog/nav.discord/nav.x(3) — never wired into the header; thefooter.*equivalents of these are the ones actually used.Keys kept (not dead despite a quick glance):
temp.*has a live consumer inroutes/temp.tsx;workspace.lite.providers.title/description/useChinaandzen.api.error.regionNotAllowedare referenced only inside commented-out JSX //* */blocks (future-use intent), so I left them in place.AI tooling used: Detail: Dead Code.
How did you verify your code works?
rgconfirmed zero production references (outsidei18n/and test files) for each removed key, whilefooter.changelogand other live keys are still referenced as a sanity check on the search.cd packages/console/app && npx tsgo --noEmit— passes (exit 0).cd packages/console/app && bun test— 7/7 pass (the two unrelated test files:providerUsage.test.ts,rateLimiter.test.ts).Screenshots / recordings
N/A — no UI change (removed keys were never rendered).
Checklist
History
Dead Code PRs can be configured here.