Skip to content

chore: remove dead Ukrainian i18n override keys - #36

Open
detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-dead-ukrainian-i18n-override-keys-428f05
Open

detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-dead-ukrainian-i18n-override-keys-428f05

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Removes 38 Ukrainian translation override keys from packages/console/app/src/i18n/uk.ts that have no live production consumer (any t("...") call-site) in packages/console/app. Each removed key also exists in en.ts, so the ...en spread continues to supply an English fallback at runtime — no behavior change, and uk.ts has no satisfies Dict constraint, so there is no type error.

The dead keys fall into groups whose consuming UI was removed in earlier commits:

  • go.testimonials.* (21) — the /go testimonials section was removed.
  • go.privacy.* (5) — the /go privacy section was removed.
  • go.graph.free / freePill / aria (3) — the Go usage graph was redesigned; only go.graph.go / label / usageLimits remain in use.
  • go.cta.start (1) — replaced by the go.cta.template / text / price / promo template.
  • go.faq.a5.beforeExceptions / exceptionsLink (2) — the Go FAQ-5 answer was rewritten to use go.faq.a5.body.
  • common.contactUs (1) — orphaned by the Go privacy-section removal (the distinct workspace.billing.contactUs key is still live).
  • download.hero.subtitle (1) — the download hero subtitle was removed from routes/download.
  • workspace.keys.table.lastUsed (1) — the "last used" column was removed from the API keys table.
  • nav.changelog / nav.discord / nav.x (3) — never wired into the header; the footer.* equivalents of these are the ones actually used.

Keys kept (not dead despite a quick glance): temp.* has a live consumer in routes/temp.tsx; workspace.lite.providers.title / description / useChina and zen.api.error.regionNotAllowed are referenced only inside commented-out JSX / /* */ blocks (future-use intent), so I left them in place.

AI tooling used: Detail: Dead Code.

How did you verify your code works?

  • rg confirmed zero production references (outside i18n/ and test files) for each removed key, while footer.changelog and other live keys are still referenced as a sanity check on the search.
  • cd packages/console/app && npx tsgo --noEmit — passes (exit 0).
  • cd packages/console/app && bun test — 7/7 pass (the two unrelated test files: providerUsage.test.ts, rateLimiter.test.ts).

Screenshots / recordings

N/A — no UI change (removed keys were never rendered).

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

History


Dead Code PRs can be configured here.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • No issue referenced. Please add Closes #<number> linking to the relevant issue.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants