chore: remove dead French translation keys from fr.ts - #35
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Removed 48 unreferenced French translation overrides from packages/console/app/src/i18n/fr.ts. These keys have no t() call-sites anywhere in the codebase: the testimonials (deliberately removed from the go page in PR anomalyco#28368), go.privacy section (removed), go.graph/cta/faq variants that were never wired, nav.changelog/discord/x (header uses only footer.* equivalents), workspace.referral status/source/apply.* keys emitted as raw data-attributes rather than via t(), workspace.keys.table.lastUsed (table uses an empty ), and download.hero.subtitle (never rendered). The i18n system uses a ...en spread with satisfies Dict, so all English values remain available as fallback and removing these overrides changes no runtime behavior.
How did you verify your code works?
Verified via ripgrep that none of the removed keys are referenced by any t() call outside the i18n dictionary files, confirmed the type-check passes (cd packages/console/app && npx tsgo --noEmit), and reviewed the diff against the dead-code removal guidelines.
History
Dead Code PRs can be configured here.