refactor(console): remove unused German translation overrides - #33
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
detail-app
Bot
changed the title
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Remove 36 lines (33 keys) of German translation overrides in
packages/console/app/src/i18n/de.tsthat have zero production references. The German dict spreads{ ...en, ...overrides }, so an override with no reader silently falls back to English. Each removed key was confirmed unreferenced via ripgrep across the full repo (excluding i18n dict files):go.cta.start,go.graph.free/freePill/aria— the Go route usesgo.cta.text+templateandgo.graph.go/label/usageLimits.go.testimonials.*quote/title lines — testimonials now render with hardcoded strings.go.privacy.*(5 keys) — the Go route has no privacy section.go.faq.a5.beforeExceptions/exceptionsLink— FAQ q5 usesgo.faq.a5.body.workspace.keys.table.lastUsed,workspace.referral.rewards.subtitle/empty, thereward.source.*/reward.status.*/apply.{noGo,preview,action}cluster — unused bygo-referral.tsx.download.hero.subtitle— the download hero usesdownload.hero.title+home.promo.*+ button.How did you verify your code works?
Each removed key was verified via ripgrep to have no callers outside the i18n/*.ts files themselves.
Screenshots / recordings
N/A — no UI changes.
Checklist