Skip to content

chore: remove dead Danish translation keys - #32

Open
detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-dead-danish-translation-keys-b6b940
Open

detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-dead-danish-translation-keys-b6b940

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #32

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Removes 48 unused Danish (da.ts) translation overrides that have zero production consumers anywhere in the codebase. Each key was confirmed via ripgrep to appear only inside the i18n/.ts files. The keys were orphaned by earlier commits that removed their callers (e.g. the Go page testimonials section, the Go privacy section, the workspace keys "Last Used" column, the referral rewards subtitle/empty fallbacks, and the referral source/status/apply button keys replaced by the new description. / action.* scheme).

Keys removed:

  • nav.changelog, nav.discord, nav.x (born dead; footer.* siblings used)
  • go.cta.start (replaced by go.cta.template/text/price/promo)
  • go.graph.free, go.graph.freePill, go.graph.aria (free-usage bar removed)
  • go.testimonials.* (21 keys; testimonials section removed from /go)
  • go.privacy.* (5 keys; privacy section removed from /go)
  • go.faq.a5.beforeExceptions, go.faq.a5.exceptionsLink (replaced by go.faq.a5.body)
  • workspace.keys.table.lastUsed (Last Used column removed)
  • workspace.referral.rewards.subtitle, rewards.empty (replaced by title/description)
  • workspace.referral.reward.source.{pendingInvitee,available,applied}, reward.status.{applied,pendingInviter,pendingInvitee}, apply.{noGo,preview,action} (replaced by description.* / action.* scheme)
  • download.hero.subtitle (download hero restructured)

How did you verify your code works?

Each removed key was verified via ripgrep to have no callers outside the i18n/*.ts files themselves.

Screenshots / recordings

N/A — no UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants