Skip to content

chore: remove orphaned DesktopPromo component - #31

Open
detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-orphaned-desktoppromo-component-e1bfb2
Open

detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-orphaned-desktoppromo-component-e1bfb2

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Removes the unused DesktopPromo SolidJS component
(packages/console/app/src/component/desktop-promo.tsx) and its companion
stylesheet (desktop-promo.css). These had no production or test consumers:
the only call-site (<DesktopPromo /> in app.tsx) was deliberately removed
in 96ff82a ("fix(console): remove desktop promo overlay"), leaving both
files orphaned. Their shared desktop-tabs-landscape.mp4 asset,
strip from ~/lib/language, and the home.promo.body/home.promo.cta
i18n keys remain used elsewhere (routes/download/index.tsx), so this
deletion has no cascading effect.

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Removes dead code: the DesktopPromo overlay component and its CSS were
left orphaned when the overlay's sole consumer was removed in
96ff82a ("fix(console): remove desktop promo overlay"). With no
imports or render references anywhere in the codebase (verified via
codebase-wide grep), neither file is reachable; both are safe to delete.

How did you verify your code works?

  • npx tsgo --noEmit (in packages/console/app) passes cleanly.
  • bun test (in packages/console/app): 7/7 tests pass.
  • git diff --stat confirms only the two intended files are removed
    (163 deletions, no other changes).

Screenshots / recordings

N/A — removal of unreferenced code, no UI behavior change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

AI model: Detail: Dead Code

History


Dead Code PRs can be configured here.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • No issue referenced. Please add Closes #<number> linking to the relevant issue.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants