chore: remove orphaned DesktopPromo component - #31
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
DesktopPromoSolidJS component(
packages/console/app/src/component/desktop-promo.tsx) and its companionstylesheet (
desktop-promo.css). These had no production or test consumers:the only call-site (
<DesktopPromo />inapp.tsx) was deliberately removedin 96ff82a ("fix(console): remove desktop promo overlay"), leaving both
files orphaned. Their shared
desktop-tabs-landscape.mp4asset,stripfrom~/lib/language, and thehome.promo.body/home.promo.ctai18n keys remain used elsewhere (
routes/download/index.tsx), so thisdeletion has no cascading effect.
Issue for this PR
Closes #
Type of change
What does this PR do?
Removes dead code: the
DesktopPromooverlay component and its CSS wereleft orphaned when the overlay's sole consumer was removed in
96ff82a ("fix(console): remove desktop promo overlay"). With no
imports or render references anywhere in the codebase (verified via
codebase-wide grep), neither file is reachable; both are safe to delete.
How did you verify your code works?
npx tsgo --noEmit(inpackages/console/app) passes cleanly.bun test(inpackages/console/app): 7/7 tests pass.git diff --statconfirms only the two intended files are removed(163 deletions, no other changes).
Screenshots / recordings
N/A — removal of unreferenced code, no UI behavior change.
Checklist
AI model: Detail: Dead Code
History
Dead Code PRs can be configured here.