feat: make AgentExecutor a functional interface with default cancel m… - #1028
Open
malladinagarjuna2 wants to merge 2 commits into
Open
feat: make AgentExecutor a functional interface with default cancel m…#1028malladinagarjuna2 wants to merge 2 commits into
malladinagarjuna2 wants to merge 2 commits into
Conversation
kabir
requested changes
Aug 11, 2026
| */ | ||
| void cancel(RequestContext context, AgentEmitter emitter) throws A2AError; | ||
| default void cancel(RequestContext context, AgentEmitter emitter) throws A2AError { | ||
| throw new org.a2aproject.sdk.spec.TaskNotCancelableError("Agent execution is not cancelable."); |
Collaborator
There was a problem hiding this comment.
Please use an import rather than a FQN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR converts the
AgentExecutorinterface into a@FunctionalInterfaceby providing a default implementation for thecancelmethod, allowing developers to define simple agents using lambda expressions.Fixes #1009
The Problem
Previously,
AgentExecutorrequired developers to implement two methods:executeandcancel. Because there were two abstract methods, it was impossible to use a lambda expression (e.g.(context, emitter) -> { ... }) to implement an agent. This forced developers to write verbose boilerplate even for simple fire-and-forget agents that do not require cancellation logic.The Solution
@FunctionalInterface: Explicitly markedAgentExecutoras a functional interface.cancelImplementation: Converted thecancelmethod to adefaultmethod. If an agent developer does not override it, it now correctly throws aTaskNotCancelableError("Agent execution is not cancelable.")by default, conforming to the existing A2A error specification.