-
Notifications
You must be signed in to change notification settings - Fork 2
UN-4010 [FEAT] Support every API deployment request parameter via a generated transport #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f68924a
c1ab0af
04d997d
d0130d0
e84a935
c291e36
ed89066
d704489
68e83c0
20b686b
981e659
29d4ac3
e210cdf
f8f13f3
49acebd
a24afd2
f1bdd97
22ed443
0882b45
4d3c4a9
19a5644
54f09f4
27dd806
114aef8
a77ef6a
5ae45fd
38b53dc
0c9d545
d67dda4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| src/unstract/api_deployments/sdk_docstudio/** linguist-generated=true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,12 @@ authors = [ | |
| {name = "Zipstack Inc", email = "devsupport@zipstack.com"}, | ||
| ] | ||
| dependencies = [ | ||
| # The transport layer is generated against httpx; attrs backs its models. | ||
| # Upper-bounded because the generated code is written against one minor | ||
| # series: a bump has to be regenerated and re-tested, not resolved into. | ||
| "httpx>=0.27,<0.29", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Medium] [Lens 16, 14] — "Kept for its exception classes" understates what The comment reads as though So the package now ships two HTTP stacks, and a maintainer reading this line would not know that. That matters for the next person deciding whether Fix: say so — e.g. " |
||
| "attrs>=23.2", | ||
| # Kept for its exception classes, which callers catch by name. | ||
| "requests>=2.32.3", | ||
| "tenacity>=8.2.0", | ||
| "click>=8.1", | ||
|
|
@@ -27,9 +33,6 @@ classifiers = [ | |
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| ] | ||
|
|
||
| [project.scripts] | ||
| unstract = "unstract.cli:main" | ||
|
|
||
| [build-system] | ||
| requires = ["hatchling"] | ||
| build-backend = "hatchling.build" | ||
|
|
@@ -64,6 +67,9 @@ lint = [ | |
|
|
||
| [tool.ruff] | ||
| line-length = 88 | ||
| # Generated and vendored code is overwritten wholesale by its refresh script, so | ||
| # a lint finding there can never be fixed in place. | ||
| extend-exclude = ["src/unstract/api_deployments/sdk_docstudio", "tests/baseline"] | ||
|
|
||
| [tool.ruff.lint] | ||
| select = ["E", "F", "W", "I"] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[High] [Lens 7, 16] — This command does not work
Run verbatim against the worktree:
unstract.clone.cli:cliis a@click.group()with a single@cli.command("clone")(src/unstract/clone/cli.py:69-74), so the flags must follow the wordclone. The repo's own test gets this right —tests/clone/test_cli.py:66-69invokes with["clone", "--source-url", …].This PR removes the
unstractconsole script and points every user here, so a user upgrading past this release losesunstract clone …and is handed a replacement that errors out.python -m unstract.clone --helpat:111does work, so they can discoverCommands: cloneand recover — but the copy-pasteable example is broken.The deleted
tests/test_cli_top_level.pywas the only test exercising a documented CLI entry point end to end, which is why this went unnoticed.Fix: write the commands as
python -m unstract.clone clone …, or collapseclito a bare@click.command()so the module invocation matches the documented one (thentests/clone/test_cli.pydrops the"clone"argument).