Add USB tether transport with source-timed A/V - #29
Draft
YashasVM wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
USB should provide a lower-jitter, lower-latency link without adding another phone encoder or re-encoding ISO video. The shared timestamp fix also addresses the existing A/V drift risk on both Wi-Fi and USB.
Validation
python -m pytest -q— 30 passed:app:testDebugUnitTest :app:lintDebug :app:assembleDebug— passed, including native builds for arm64-v8a, armeabi-v7a, x86, and x86_64ctest --test-dir obs-plugin/build -C Release --output-on-failure— native media clock test passedBefore merge
This stays draft until a physical Android phone/cable run records Wi-Fi-vs-USB p50/p95 latency, maximum A/V skew, a 30-minute 1080p60 soak, and five cable unplug/replug recoveries as required by the repository performance policy.