Skip to content

Remove circl; Refine "[REALITY] SECTION" comments - #37

Merged
RPRX merged 3 commits into
mainfrom
remove-circl
Oct 12, 2026
Merged

Remove circl; Refine "[REALITY] SECTION" comments#37
RPRX merged 3 commits into
mainfrom
remove-circl

Conversation

@Fangliding

@Fangliding Fangliding commented Sep 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@Fangliding
Fangliding marked this pull request as draft September 10, 2026 02:02
@Fangliding

Fangliding commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

不对 有一个问题 现在xray传入的是解析完的私钥 但是go的函数只收seed

@RPRX

RPRX commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

每次都计算一遍有点蠢了，试试能不能 linkname 吧，不然貌似只能改接口了

顺便标一下 REALITY 专属代码段 #30 (comment)

@RPRX

RPRX commented Sep 20, 2026

Copy link
Copy Markdown
Member

@Fangliding rebase 然后试试 linkname，实在不行就改接口

@RPRX
RPRX force-pushed the main branch 2 times, most recently from 65bac6a to 3c98159 Compare September 21, 2026 00:15
@RPRX RPRX mentioned this pull request Sep 21, 2026
Merged
@Fangliding

Fangliding commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

标准库早不能link了 而且本来json那边写的就是key 还额外解析了一次传进来的
image

@RPRX

RPRX commented Sep 21, 2026

Copy link
Copy Markdown
Member

主要是不想每次都重新计算一遍，那你改接口吧，另外你看看 #40

@RPRX

RPRX commented Sep 21, 2026

Copy link
Copy Markdown
Member

顺便把依赖都升到最新版吧，uTLS 那个和 Xray-core 对齐

@Fangliding

Fangliding commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

我改成直接存private key那个结构了 这样就也不用重新计算了

@Fangliding

Fangliding commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

顺便把依赖都升到最新版吧，uTLS 那个和 Xray-core 对齐

依赖最后会被最上面的仓库拉平的 这里改了也没啥用 xray用那个版本主要是为了我之前写的ECH隐藏alpn 除此之外没啥很必要的

@RPRX

RPRX commented Sep 21, 2026

Copy link
Copy Markdown
Member

对齐一下依赖版本看着清爽些，另外这 fmt 采用哪家的 @yuhan6665

另外你还是得确认下这个 PR 现在这样改以及 #40 不会带来并发竞态问题

@Fangliding

Fangliding commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

我用的就是vsc默认的gopls
竞态应该不会有 这个私钥是不可变的
我的说法就是 从seed计算mlkem私钥开销比较大而且反正也要break所以我弄成这样 25519我真觉得没必要 用了几万年的tls握手一样也是要解析一次 现在这样就好

@RPRX

RPRX commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

这些私钥当然没变，只是它们是结构体，用的时候可能会拿内部变量做缓存所以不能并发用，以前我看到过这种，忘了是哪个

也可能当时看到的是 hash sum 啥的，总之你研究下

@RPRX

RPRX commented Oct 3, 2026

Copy link
Copy Markdown
Member

@Fangliding 有进展吗

@Fangliding

Fangliding commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

一直没问题 就是更新的时候需要调整一下 core 的代码 core 那边的pr不发是因为只有等这边合并才能产生需要的 commit hash

@Fangliding

Fangliding commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

哦对了主仓库的issue被轰炸了 不知道为什么机器人没法转发到群里（也算是好事） 我没法ban人还得你去看下 而且最近出一键关闭了
https://github.blog/changelog/2026-08-27-close-all-open-contributions-authored-by-a-blocked-user/

@manamansor

manamansor commented Oct 11, 2026

Copy link
Copy Markdown

He

@RPRX

RPRX commented Oct 12, 2026

Copy link
Copy Markdown
Member

@Fangliding 这个 PR 对 [REALITY] SECTION 的注释风格有点乱，你把这个仓库里的都改成一样的风格吧，或许删掉多余的 /

@Fangliding

Fangliding commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

我没有动过注释部分 也不是我做的 这里面改的缩进估计是format自动干的
我不知道你要啥风格的

@RPRX

RPRX commented Oct 12, 2026

Copy link
Copy Markdown
Member

// [REALITY] SECTION: 就这样简单点吧，其它文件的也改改、fmt 一下

@RPRX RPRX changed the title Remove circl Remove circl; Refine "[REALITY] SECTION" comments Oct 12, 2026
@RPRX
RPRX marked this pull request as ready for review October 12, 2026 18:32
@RPRX
RPRX merged commit 14cefac into main Oct 12, 2026
@RPRX
RPRX deleted the remove-circl branch October 12, 2026 18:35
@RPRX

RPRX commented Oct 13, 2026

Copy link
Copy Markdown
Member

Xray-core 那边我改好了，等我升级 REALITY 库时一起 commit 吧

@RPRX RPRX mentioned this pull request Oct 13, 2026
Merged
RPRX added a commit that referenced this pull request Oct 14, 2026
@JkLondon @RPRX
Config.PrivateKey: []byte -> *ecdh.PrivateKey (#40)
83f6217 
#40 (comment)
#40 (comment)
#37 (comment)

---------

Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fangliding @RPRX @manamansor