Skip to content

Allow PHP-Only Block Registration - #10932

Closed
t-hamano wants to merge 23 commits into
WordPress:trunkfrom
t-hamano:64639-php-auto-register-block
Closed

Allow PHP-Only Block Registration#10932
t-hamano wants to merge 23 commits into
WordPress:trunkfrom
t-hamano:64639-php-auto-register-block

Conversation

@t-hamano

@t-hamano t-hamano commented Feb 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/64639

Use of AI Tools

I am using the Cursor editor and the AI ​​model is auto-selected. I have reviewed all the code myself.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@t-hamano
t-hamano force-pushed the 64639-php-auto-register-block branch 2 times, most recently from 6b3535e to 7d228d9 Compare February 14, 2026 13:36
@github-actions

github-actions Bot commented Feb 14, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
t-hamano force-pushed the 64639-php-auto-register-block branch from ec4f677 to 6a7c802 Compare February 14, 2026 14:06
@t-hamano
t-hamano force-pushed the 64639-php-auto-register-block branch from 6a7c802 to 691cdf5 Compare February 14, 2026 14:07
@t-hamano
t-hamano marked this pull request as ready for review February 14, 2026 14:30
@github-actions

github-actions Bot commented Feb 14, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, westonruter, ramonopoly, mcsf, oandregal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter
westonruter reviewed Feb 14, 2026
View reviewed changes
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
t-hamano
t-hamano commented Feb 16, 2026
View reviewed changes
Comment thread src/wp-includes/default-filters.php Outdated
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_editor_format_library_assets' );
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_block_editor_script_modules' );
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_global_styles_css_custom_properties' );
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_auto_register_blocks' );

@t-hamano t-hamano Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial approach was to collect the blocks that should be registered and expose them as editor settings in the get_block_editor_settings() function. Now, based on this feedback, I output them as JS inline variables via a new action hook.

westonruter
westonruter reviewed Feb 16, 2026
View reviewed changes
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
Comment thread src/wp-includes/script-loader.php Outdated
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
Comment thread src/wp-includes/script-loader.php Outdated
t-hamano and others added 6 commits February 17, 2026 15:11
@t-hamano @westonruter
Make PHPDoc comment third-person
4ede6de 
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@t-hamano @westonruter
Add @see tag
723bd9b 
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@t-hamano @westonruter
Make PHPDoc comment third-person
936b6bf 
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@t-hamano @westonruter
Remove default value from filter hook
c1c194a 
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@t-hamano
Merge branch 'trunk' into 64639-php-auto-register-block
22fee8f
@t-hamano
Relocate function and add underscore prefix
ef9b560
westonruter
westonruter reviewed Feb 17, 2026
View reviewed changes
Comment thread tests/phpunit/tests/block-supports/auto-register.php
Comment thread src/wp-includes/block-supports/auto-register.php Outdated
Comment thread src/wp-includes/block-supports/auto-register.php
Comment thread src/wp-settings.php Outdated
t-hamano and others added 3 commits February 17, 2026 15:45
westonruter
westonruter approved these changes Feb 17, 2026
View reviewed changes

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-hamano t-hamano mentioned this pull request Feb 17, 2026
Merged
@github-actions github-actions Bot mentioned this pull request Feb 17, 2026
Closed
@t-hamano

t-hamano commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@oandregal, Based on your suggestion, I've added server-side type checking in 658b7af. I'd be happy to see if this is what you wanted.

@oandregal

oandregal commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@t-hamano thank you, that's great :) Code changes look good.

@t-hamano

t-hamano commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@oandregal Thanks for the review! After committing this PR to core, I would like to backport similar changes to Gutenberg.

mcsf
mcsf reviewed Feb 17, 2026
View reviewed changes
Comment thread src/wp-includes/block-supports/auto-register.php
t-hamano and others added 2 commits February 17, 2026 20:22
@t-hamano @mcsf
Use null Coalescing Operator
e2b5ad4 
Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com>
@t-hamano
Fix PHP fatal error
7f465c3
mcsf
mcsf approved these changes Feb 17, 2026
View reviewed changes

@mcsf mcsf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61661
GitHub commit: 8f6d312

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Feb 17, 2026
@t-hamano t-hamano mentioned this pull request Feb 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oandregal oandregal oandregal left review comments
@ramonjd ramonjd ramonjd left review comments
@westonruter westonruter westonruter approved these changes
@mcsf mcsf mcsf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@t-hamano @oandregal @westonruter @mcsf @ramonjd