Conversation
prepare.php ran `npm run build`, which writes the built files to build/, while the test suite runs against src/. Since core r63983 a test asserts that the jQuery files exist under src/wp-includes/js/jquery/, so every host using the runner fails four tests. Run `npm run build:dev` instead. It writes the built files into src/ and is the same build that WordPress core's own PHPUnit workflow runs. Fixes WordPress#350.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kittenkamala
approved these changes
Oct 6, 2026
Collaborator
|
Thank you so much for catching this. Would be great to have some hosts test on their systems to confirm the change to using build:dev is effective. Maybe @jazzsequence and @chrisdavidmiles could test on Pantheon and BlueHost systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350.
Problem
Since core r63983, host reports fail four tests:
Tests_Dependencies_jQuery::test_jquery_files_existforjquery.js,jquery.min.js,jquery-migrate.jsandjquery-migrate.min.js.On the results site, r63982 has 22 passed and 2 failed reports. r63983 has 3 passed and 27 failed, and r64091 is still at 3 and 24. Only core's own reporter passes.
prepare.phprunsnpm run build, which writes the built files tobuild/. The test suite runs againstsrc/, which isABSPATHin the generatedwp-tests-config.php. The new test asserts that the jQuery files exist undersrc/wp-includes/js/jquery/, and only the development build creates that directory.Fix
Run
npm run build:devinstead. It writes the built files intosrc/, and it is the build that core's own PHPUnit workflow runs:npm ci, thennpm run build:dev.What changes for hosts
Tests_Basic::test_build_wp_version_does_not_end_with_srcis now skipped, becausebuild/is no longer produced. Core's own workflow skips it for the same reason.build/directory, which was 152 MB in my run.Verification
Real end to end runs of
prepare.phpandtest.phpagainst trunk r64092, PHP 8.5, MySQL 9.7.master:src/wp-includes/js/jquery/does not exist after prepare, and the four tests fail with the same messages as in host-tests failing since r63983 (missing/invalid jQuery paths?) #350.src/, andTests_Dependencies_jQuerypasses with 7 tests and 48 assertions.dependencies,scripts,blocks,restapi, and the five test files that reference built paths, about 4,800 tests): the only differences are the four fixed tests and the one skipped test above.masterends with 4 failures, the same four tests, and 73 skipped. This branch ends with no failures and 74 skipped. The extra skip is the build version test above.php -l,phpcsandgit diff --checkare clean.Notes
npm run build. It would need the same one-word update.continue-on-error. That is outside this PR.Use of AI
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, implementation, verification harness, and PR wording. I reviewed the reasoning and test results, and I take responsibility for the contribution.