Skip to content

Generate random salts in the prepared wp-tests-config.php #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekamran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate random salts in the prepared wp-tests-config.php #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions prepare.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,22 @@
// Don't validate the TLS certificate. Useful for local environments.
$contents = file_get_contents( $runner_vars['WPT_PREPARE_DIR'] . '/wp-tests-config-sample.php' );

/*
* Give the generated config its own random salts instead of the sample's
* placeholder phrases. WordPress treats the placeholder as undefined and
* generates salts in the database on first use, so this is not a security
* fix. It makes the generated config follow its own instructions and saves
* the test install from priming salt options. Each placeholder gets a fresh
* value, and hex keeps the value safe inside the single quotes.
*/
$contents = preg_replace_callback(
"/'put your unique phrase here'/",
function () {
return "'" . bin2hex( random_bytes( 32 ) ) . "'";
},
$contents
);

/*
* Prepare a script for logging system information.
*
Expand Down
Loading