Skip to content

Repair wp/6.3 branch Actions: Pass debug step arguments through to wp-env - #83806

Draft
desrosj wants to merge 1 commit into
fix-actions-6.3/fix-flaky-site-editor-url-navigationfrom
fix-actions-6.3/fix-debug-step-arguments
Draft

desrosj wants to merge 1 commit into
fix-actions-6.3/fix-flaky-site-editor-url-navigationfrom
fix-actions-6.3/fix-debug-step-arguments

Conversation

@desrosj

@desrosj desrosj commented Sep 30, 2026

Copy link
Copy Markdown
Member

Part of #82930.

What?

Adds -- right after npm run wp-env in each command of unit-test.yml's "Docker container debug information" step, so npm passes the whole command through to wp-env unchanged.

Why?

Without it, npm treats the rest of the arguments as its own: it drops the -- separator and swallows short flags such as -m, -i and -a. None of the step's commands ran as written:

  • mysql -- --version, php -- --version and phpunit -- --version reached wp-env as its own --version flag, so each printed the wp-env version.
  • php -m and php -i ran as a bare php, and locale -a as a bare locale.

The step passed without logging any of the information it exists for.

Now that the commands really run, the mysql --version line fails: this branch's floating mariadb image is MariaDB 11.0 or later, which no longer includes the mysql alias for the mariadb client. That will be addressed separately.

Upstream

trunk has used the same form (npm run wp-env-test -- run …) since #75341.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 30, 2026
@desrosj desrosj self-assigned this Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj force-pushed the fix-actions-6.3/fix-debug-step-arguments branch from d8ac8c6 to 15e8cfa Compare October 2, 2026 20:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant