Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83742
September 30, 2026 00:42
desrosj
force-pushed
the
fix-actions-6.3/fix-debug-step-arguments
branch
from
October 2, 2026 20:00
d8ac8c6 to
15e8cfa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82930.
What?
Adds
--right afternpm run wp-envin each command ofunit-test.yml's "Docker container debug information" step, so npm passes the whole command through towp-envunchanged.Why?
Without it, npm treats the rest of the arguments as its own: it drops the
--separator and swallows short flags such as-m,-iand-a. None of the step's commands ran as written:mysql -- --version,php -- --versionandphpunit -- --versionreachedwp-envas its own--versionflag, so each printed thewp-envversion.php -mandphp -iran as a barephp, andlocale -aas a barelocale.The step passed without logging any of the information it exists for.
Now that the commands really run, the
mysql --versionline fails: this branch's floatingmariadbimage is MariaDB 11.0 or later, which no longer includes themysqlalias for themariadbclient. That will be addressed separately.Upstream
trunkhas used the same form (npm run wp-env-test -- run …) since #75341.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code