Skip to content

Check through code base for use of "magic numbers" #513

Description

@jrfnl

Most notably in the cURL transport class, hard-coded numbers are used for various cURL error codes.

Task:

  • Go through the code base to find these numbers
  • Check if there is a PHP constant which can be used instead and if that constant is available in all supported PHP versions and if so, switch over
  • For "magic numbers" which don't have a PHP native constant, create a descriptive class constant instead and use that.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions