Skip to content

Should the write functions use int64_t instead of long for row_count. #282

Description

@khc8749

Is there a good reason not to change these functions from

readstat_error_t readstat_begin_writing_dta(readstat_writer_t *writer, void *user_ctx, long row_count);
readstat_error_t readstat_begin_writing_por(readstat_writer_t *writer, void *user_ctx, long row_count);
readstat_error_t readstat_begin_writing_sas7bcat(readstat_writer_t *writer, void *user_ctx);
readstat_error_t readstat_begin_writing_sas7bdat(readstat_writer_t *writer, void *user_ctx, long row_count);
readstat_error_t readstat_begin_writing_sav(readstat_writer_t *writer, void *user_ctx, long row_count);
readstat_error_t readstat_begin_writing_xport(readstat_writer_t *writer, void *user_ctx, long row_count);

to

readstat_error_t readstat_begin_writing_dta(readstat_writer_t *writer, void *user_ctx, int64_t row_count);
readstat_error_t readstat_begin_writing_por(readstat_writer_t *writer, void *user_ctx, int64_t row_count);
readstat_error_t readstat_begin_writing_sas7bdat(readstat_writer_t *writer, void *user_ctx, int64_t row_count);
readstat_error_t readstat_begin_writing_sav(readstat_writer_t *writer, void *user_ctx, int64_t  row_count);
readstat_error_t readstat_begin_writing_xport(readstat_writer_t *writer, void *user_ctx, int64_t  row_count);

The read functions use int64_t for row_count

Activity

  1. evanmiller commented on Dec 17, 2022

    @evanmiller
    Contributor

    That would be a better design but would represent an API change as long is 32-bit on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions