Repository navigation
fix(profiles): a mistyped profile leaves no state file; doctor suggests setup - #735
Merged
Merged
Conversation
…ts setup `max typoprofile chats list` refused the profile but first wrote profiles/typoprofile.json: the adapter and other callers read only the viewer id through readState(), which invents and saves a device identity. That file then listed the typo as a profile in "name a profile" and in completion. Callers that only need the viewer id now use a read-only SessionStore#viewerId(); the device identity is still saved before login. `session end` for a profile with no state file no longer creates one. doctor without a token suggested `session start`; the README and the "no session" error use `setup`. README: a global install puts the agent skill in ~/.claude/skills and ~/.agents/skills, and MAX_INSTALL_AGENT=none turns that off. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
leemour
force-pushed
the
fix/ux-68-max-small-items
branch
from
October 18, 2026 18:23
bbdc34e to
61f428d
Compare
Merged
leemour
added a commit
that referenced
this pull request
Oct 18, 2026
Version and the dated changelog for 0.63.0: «Не выпущено» → `0.63.0 — 19.10.2026`, package.json, src/version.ts. Nothing else. Since v0.62.0: #733, #734, #735, #737, #738. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: small items from the public-readiness review of max (UX-68).
Why
max typoprofile chats listrefused the profile, but leftprofiles/typoprofile.jsonbehind. From then on "name a profile" andmax completelistedtypoprofileas a profile on this computer.max <profile> doctorwithout a token suggestedsession start, while the README and the "no session" error saysetup.~/.claude/skillsand~/.agents/skills; the README did not say so.What
SessionStore#viewerId()reads the viewer id without creating the state file. Every caller that only needed the viewer id (adapterself, records, people, live, serve) uses it.readState()stays the writer before login, so the device identity is still saved before it is used.forget()(session end) no longer creates a state file for a profile that has none.setup.MAX_INSTALL_AGENT=none.Testing
src/program.test.ts: a mistyped profile is refused and not listed afterwards (fails without the fix).chats list,messages list,doctor,session end,messages send --dry-run,contacts list,inbox,watch --once,mcpwith a typo profile leave no file inprofiles/.pnpm typecheck,pnpm lint,pnpm test(1523 passed),pnpm docs:check,pnpm docs:lint.🤖 Generated with Claude Code