Conversation
Update to follow the same logic and perform calibration properly.
Author
|
Quick question: I am not sure why for the second pattern (Pattern 2) from line 72 to line 115, it was not using the function yOCTPhotobleachTile. I followed the same logic but just wondering if we should. I ensured it works as is |
MyYo
requested changes
Jul 4, 2025
MyYo
left a comment
MyYo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, a few changes requested
- skipHardware default set to false - Standard notation for octProbePath from demos
MyYo
requested changes
Jul 10, 2025
| nPasses = 4; % Keep as low as possible. If galvo gets stuck, increase number | ||
|
|
||
| %% Define pattern template | ||
| [~, fileName, ~] = fileparts(octProbePath); % Extract filename from path to get lens magniciation |
Collaborator
There was a problem hiding this comment.
Sorry, I didn't mean for you to extract lens from file parts
You can instead use:
lens = '40x'
octProbePath = yOCTGetProbeIniPath(lens,'OCTP900'); % Inputs to the function are OBJECTIVE_DEPENDENT: '10x' or '40x', and scanning system dependent 'OCTP900' or ''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the same logic and perform calibration properly.