feature:Unit Tests for Site.py - #85
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the Site class functionality, focusing on verifying standard and edge-case prefix behaviors, as well as ensuring proper formatting in link generation and string representations.
- Added tests to validate registration of standard prefixes and handling of edge cases (empty strings, None, unwanted cases).
- Included tests for link generation and magic method (repr, str, hash) behaviors for both Site and WildcardPage classes.
DiFronzo
self-requested a review
June 2, 2025 10:49
jhsoby
pushed a commit
that referenced
this pull request
Jul 21, 2025
It confirms that standard prefixes like 'en' and 'de' are properly
registered, while also validating the behavior with edge cases such as
an empty string (''), None, capitalized forms like 'UPPERcase', and
prefixes with leading/trailing whitespace like ' en '. The tests also
verify that the class remains working when unknown or invalid prefixes
(like 'zz', 'not_in_map', or the integer 42) are passed and they are not
added to the interwikimap.
<!--
This PR fixes the Issue
-->
- [x] 🍕 Feature
- [x] ✅ Test
Fixes #79
- [x] 👍 yes
- [ ] 📜 README.md
- [ ] 📖 own file under the docs folder
- [x] 🙅 no documentation needed
<!--
Write about changing templates or modules on-wiki in order to accomodate
changes in this PR
-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It confirms that standard prefixes like 'en' and 'de' are properly registered, while also validating the behavior with edge cases such as an empty string (''), None, capitalized forms like 'UPPERcase', and prefixes with leading/trailing whitespace like ' en '. The tests also verify that the class remains working when unknown or invalid prefixes (like 'zz', 'not_in_map', or the integer 42) are passed and they are not added to the interwikimap.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #79
Tested?
Added to documentation?