Skip to content

Exchange setup.py for pyproject.toml - #64

Merged
jhsoby merged 1 commit into
mainfrom
pyproject
Apr 22, 2025
Merged

Exchange setup.py for pyproject.toml#64
jhsoby merged 1 commit into
mainfrom
pyproject

Conversation

@jhsoby

@jhsoby jhsoby commented Apr 13, 2025

Copy link
Copy Markdown
Member

Exchange setup.py for the more modern approach, pyproject.toml, update requirements.txt based on current requirements, and add bot version to ukbot.py output.

This fixes #59.

Exchange setup.py for the more modern approach, pyproject.toml,
update requirements.txt based on current requirements, and
add bot version to ukbot.py output.

This fixes #59.
@jhsoby
jhsoby requested a review from DiFronzo April 13, 2025 11:25
@DiFronzo
DiFronzo requested a review from Copilot April 16, 2025 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project's packaging by replacing the legacy setup.py with a pyproject.toml file, updates dependency listings, and adds bot version information to the application output.

  • Removed setup.py in favor of pyproject.toml for a more modern package configuration.
  • Updated the logging output in ukbot.py to display the bot's version.
  • Updated dependency requirements in the new pyproject.toml file.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ukbot/ukbot.py Added version metadata using importlib.metadata and updated logging format.
setup.py Removed the legacy setup.py file.
pyproject.toml Added new packaging configuration with updated dependencies and metadata.

@DiFronzo DiFronzo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see some modernization!

@jhsoby
jhsoby merged commit 2b56913 into main Apr 22, 2025
@jhsoby
jhsoby deleted the pyproject branch April 22, 2025 09:38
jhsoby added a commit that referenced this pull request Jul 21, 2025
Exchange setup.py for the more modern approach, pyproject.toml, update
requirements.txt based on current requirements, and add bot version to
ukbot.py output.

This fixes #59.
jhsoby added a commit that referenced this pull request Jul 21, 2025
Exchange setup.py for the more modern approach, pyproject.toml, update
requirements.txt based on current requirements, and add bot version to
ukbot.py output.

This fixes #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up setup.py

3 participants