Skip to content

Remove public IP rewriting from proxy image - #540

Merged
bsuh merged 1 commit into
mainfrom
pr540
Jul 29, 2026
Merged

bsuh merged 1 commit into
mainfrom
pr540

Conversation

@bsuh

@bsuh bsuh commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

  • rename the container startup script to start.sh
  • remove public IP discovery and HAProxy set-dst configuration
  • run HAProxy as the container's main process

Test Plan:

  • bash -n proxy/src/start.sh
  • shellcheck proxy/src/start.sh
  • podman build --isolation=chroot --network=host --tag whatsapp-proxy:public-ip-removal-full-build --file /tmp/whatsapp-proxy-proxied.Dockerfile proxy/
  • podman run --detach --sysctl net.ipv4.ip_unprivileged_port_start=0 --name whatsapp-proxy-full-build-smoke localhost/whatsapp-proxy:public-ip-removal-full-build
  • podman top whatsapp-proxy-full-build-smoke pid,args
  • podman exec whatsapp-proxy-full-build-smoke haproxy -c -V -f /usr/local/etc/haproxy/haproxy.cfg
  • podman exec whatsapp-proxy-full-build-smoke /usr/local/bin/healthcheck.sh

Summary:
- rename the container startup script to `start.sh`
- remove public IP discovery and HAProxy `set-dst` configuration
- run HAProxy as the container's main process

Test Plan:
- `bash -n proxy/src/start.sh`
- `shellcheck proxy/src/start.sh`
- `git diff --check`
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2026
@bsuh
bsuh requested a review from jaltenmueller July 29, 2026 18:43
@bsuh
bsuh merged commit b3b14fd into main Jul 29, 2026
5 checks passed
@bsuh
bsuh deleted the pr540 branch July 29, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants