Fix CMS home-page pathbox: show full list on open (1.18.1) - #320
Merged
Merged
Conversation
On focus the pathbox sent its current label as the search query, filtering out every option including the active theme's home. Send an empty query while the box shows the committed label; filter only once the user types; select the text on focus. Also move the "Advanced search" toggle beside the combobox. Server-side discovery was already correct. 1.18.0 → 1.18.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMS home-page picker: show the full list on open
Symptom: with a theme active (e.g. Grey Mist), the CMS Settings → Home page combobox wouldn't list it — opening the control showed only the current selection.
Root cause (client-side):
tiger.pathbox.jssent the input's current text as the search queryqon focus. The input is pre-filled with the committed label ("— Built-in landing page —"), so opening the box "searched" for that string and filtered out every other option, including the active theme's home. The discovery service (Cms_Service_Paths) was already returning the theme correctly (verified on dev via reflection).Fix:
q(full list); filter only once the user actually types.Proven on tiger-dev: opening the picker now lists Grey Mist / Porto / TigerMarketing theme homes + CMS pages +
/docs. Patch release 1.18.1.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ