Skip to content

Quick Select Default Ring setting is invalid #91

Open

Description

@idougal

If you open the Quick Configure Menu and select Ring from the pulldown list:

The Rotational Radius turns to 138.4

This number will be described as invalid when you press submit. It then states that valid numbers are 138.1 or 139.1.

The Advanced Setting rotational radius setting states that 140 should be the default value.

Activity

  1. madgrizzle commented on Jan 27, 2020

    @madgrizzle
    Collaborator

    Thanks.. appears most entries are messed up. I had to tried to make it so that when using a mobile, the numeric keyboard popped-up. @gb0101010101 made a change to dist to move on the front page and I'll duplicate that for all the other numeric entries.

  2. gb0101010101 commented on Jan 28, 2020

    @gb0101010101
    Contributor

    This looks like the same input validation problem I mentioned in another issue. Decimal input precision should probably defined globally and enforced on all inputs. Most of the inputs are limited to 3 decimal points but noticed that UI Unit switch code returns 4 decimals which will cause errors.

  3. madgrizzle commented on Jan 28, 2020

    @madgrizzle
    Collaborator

    I changed everything to 5 (need to verify disttomove was changed) and pr'ed test1 into master to prepare for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions