Fix possible by not specifying a USER, a program in the container may run as 'root' in Dockerfile - #8
Open
begininvoke wants to merge 1 commit into
Conversation
…ay run as 'root'. This is a security hazard. If an
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
images/test_worker/Dockerfileto address something a scan flagged. It is around line 32.The Dockerfile does not set a non‑root USER, so the container's processes (including the CMD) run as root. This unnecessary privilege increases the impact of any compromise of the application – an attacker controlling a process could gain full container control. According to CWE‑250, execution with unnecessary privileges should be avoided.
Added a non‑root USER and created the user to avoid running containers as root.
For reference: rule
dockerfile.security.missing-user.missing-user, CWE-250 (Execution with Unnecessary Privileges). Rated high.I do not know the codebase, so please check the change fits how the rest of it works. Happy to adjust it or close this if the reasoning is off.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.