Repository navigation
Conversation
… instead of PyObject Null checks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes cut a lot of waste from commonly used functions being
Loop._call_soonand it's surrounding siblings. Using numeric systems is more robust and gets rid of a lot of useless python refs in the case of failure occurances. This also speeds up the brand newwinloop.loop.Futurein a few ways the main one being if callbacks were appended even though it's currently an unused sections until exposed publically.Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist