Skip to content

CMake include path issue #8

Open

Description

@derpda

Once again thank you for putting this together, and for reacting to the issues/PRs so quickly.

Issue

When using this library through

FetchContent_Declare(ByteTrackCpp
  GIT_REPOSITORY  https://github.com/Vertical-Beach/ByteTrack-cpp.git
  GIT_TAG         main
  GIT_SHALLOW     ON)
FetchContent_MakeAvailable(ByteTrackCpp)
# ...
target_link_libraries(my_lib bytetrack)

in my project, the include paths needed for the bytetrack library are not forwarded.
Checking a bit further,

get_target_property(bytetrack_INCLUDE_DIRS bytetrack INTERFACE_INCLUDE_DIRECTORIES)
message(STATUS "ByteTrack include dirs: ${bytetrack_INCLUDE_DIRS}")

shows that INTERFACE_INCLUDE_DIRECTORIES are not set.

I will open another small PR fixing this once the current one is merged!

Activity

  1. medalotte commented on Sep 1, 2022

    @medalotte
    Contributor

    Thanks! No problem, I have merged it.

  2. medalotte commented on Sep 1, 2022

    @medalotte
    Contributor

    I made a mistake on the issue to close.

  3. derpda commented on Sep 5, 2022

    @derpda
    ContributorAuthor

    Thank you for getting back to me =)
    I think this issue is fixed with PR #10!
    As mentioned in the PR, I have since made a host of other changes, if you are interested I can post PRs for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions