Skip to content

Eliminate polling latency in BinaryView search generators. #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpotchik wants to merge 1 commit into
base: dev
Choose a base branch
from
+52 −27
Open

Eliminate polling latency in BinaryView search generators. #8465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 52 additions & 27 deletions python/binaryview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9976,24 +9976,30 @@ def find_next_constant(
return result.value

class QueueGenerator:
_done = object()

def __init__(self, t: threading.Thread, results: queue.Queue):
self.thread = t
self.results = results
self._finished = False
t.start()

def __iter__(self):
return self

def __next__(self):
while True:
try:
return self.results.get(timeout=0.1)
except queue.Empty:
if not self.thread.is_alive():
try:
return self.results.get_nowait()
except queue.Empty:
raise StopIteration
if self._finished:
raise StopIteration
result = self.results.get()
if result is self._done:
# Mark exhausted and re-post the sentinel so that any
# subsequent __next__ call (including one already blocked in
# another thread) also observes completion instead of blocking
# forever waiting on a queue the worker will never write to again.
self._finished = True
self.results.put(self._done)
raise StopIteration
return result

@overload
def find_all_data(
Expand Down Expand Up @@ -10067,11 +10073,15 @@ def find_all_data(
ctypes.c_bool, ctypes.c_void_p, ctypes.c_ulonglong, ctypes.POINTER(core.BNDataBuffer)
)(lambda ctxt, addr, match: results.put((addr, databuffer.DataBuffer(handle=match))) or True)

t = threading.Thread(
target=lambda: core.BNFindAllDataWithProgress(
self.handle, start, end, buf.handle, flags, None, progress_func_obj, None, match_callback_obj
)
)
def worker():
try:
core.BNFindAllDataWithProgress(
self.handle, start, end, buf.handle, flags, None, progress_func_obj, None, match_callback_obj
)
finally:
results.put(self.QueueGenerator._done)

t = threading.Thread(target=worker)

return self.QueueGenerator(t, results)

Expand Down Expand Up @@ -10182,12 +10192,16 @@ def find_all_text(
or True
)

t = threading.Thread(
target=lambda: core.BNFindAllTextWithProgress(
self.handle, start, end, text, settings.handle, flags, graph_type, None, progress_func_obj, None,
match_callback_obj
)
)
def worker():
try:
core.BNFindAllTextWithProgress(
self.handle, start, end, text, settings.handle, flags, graph_type, None, progress_func_obj, None,
match_callback_obj
)
finally:
results.put(self.QueueGenerator._done)

t = threading.Thread(target=worker)

return self.QueueGenerator(t, results)

Expand Down Expand Up @@ -10273,12 +10287,16 @@ def find_all_constant(
ctypes.c_bool, ctypes.c_void_p, ctypes.c_ulonglong, ctypes.POINTER(core.BNLinearDisassemblyLine)
)(lambda ctxt, addr, line: results.put((addr, self._LinearDisassemblyLine_convertor(line))) or True)

t = threading.Thread(
target=lambda: core.BNFindAllConstantWithProgress(
self.handle, start, end, constant, settings.handle, graph_type, None, progress_func_obj, None,
match_callback_obj
)
)
def worker():
try:
core.BNFindAllConstantWithProgress(
self.handle, start, end, constant, settings.handle, graph_type, None, progress_func_obj, None,
match_callback_obj
)
finally:
results.put(self.QueueGenerator._done)

t = threading.Thread(target=worker)

return self.QueueGenerator(t, results)

Expand Down Expand Up @@ -10368,7 +10386,14 @@ def internal_match_callback(ctxt, offset, match):

match_callback_obj = ctypes.CFUNCTYPE(ctypes.c_bool, ctypes.c_void_p, ctypes.c_ulonglong, ctypes.POINTER(core.BNDataBuffer))(internal_match_callback)
results = queue.Queue()
t = threading.Thread(target=lambda: core.BNSearch(self.handle, json.dumps(query), None, progress_callback_obj, None, match_callback_obj))

def worker():
try:
core.BNSearch(self.handle, json.dumps(query), None, progress_callback_obj, None, match_callback_obj)
finally:
results.put(self.QueueGenerator._done)

t = threading.Thread(target=worker)
return self.QueueGenerator(t, results)

@staticmethod
Expand Down