This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Repository navigation
Decouple shared Model Target JSON helpers from core models - #3783
Merged
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
October 26, 2026 11:19 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared Model Target request fixtures and response parsing imported the recursive JSON type from
mock_vws.model_target, tying reusable API tests to the implementation they verify. Use Pydantic's publicJsonValuetype instead, retaining recursive JSON validation through the existing dependency.Towards #3738. This removes all
mock_vwsimports from these two shared helpers; the rest of the contract-suite decoupling remains separate.Validation:
git diff --checkpassed.Based on current
main. The changed files are disjoint from open PRs #3769 and #3770 and the separate server-interface PR. Hosted CI is pending.