Skip to content
This repository was archived by the owner on Oct 30, 2026. It is now read-only.

Decouple shared Model Target JSON helpers from core models - #3783

Merged
adamtheturtle merged 1 commit into
mainfrom
codex/shared-model-target-json-20261026
Oct 26, 2026
Merged

adamtheturtle merged 1 commit into
mainfrom
codex/shared-model-target-json-20261026

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Shared Model Target request fixtures and response parsing imported the recursive JSON type from mock_vws.model_target, tying reusable API tests to the implementation they verify. Use Pydantic's public JsonValue type instead, retaining recursive JSON validation through the existing dependency.

Towards #3738. This removes all mock_vws imports from these two shared helpers; the rest of the contract-suite decoupling remains separate.

Validation:

  • Existing Model Target API, failure-response and retry tests: 536 passed, 244 real-backend cases skipped.
  • Nine offline JSON round trips covering primitives, arrays, objects and nested values passed.
  • Pre-commit and pre-push hooks passed, including partition checks and all type checkers. Pylint passed for both changed modules.
  • git diff --check passed.

Based on current main. The changed files are disjoint from open PRs #3769 and #3770 and the separate server-interface PR. Hosted CI is pending.

This branch was previously deployed

2 inactive deployments
vuforia — f38fd60e Deployed Oct 26, 2026 by adamtheturtle via ci-tests (3.15, docs/) #2605
development — f38fd60e Deployed Oct 26, 2026 by adamtheturtle via pages #2478
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant