Repository navigation
Supply Model Target retry policies from backend adapters - #3766
Open
adamtheturtle wants to merge 1 commit into
Open
adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
vuforia
October 14, 2026 13:34 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared Model Target helpers currently define the real service's retry criteria, attempt limit, and delays, and track whether the real backend is active. That makes a reusable contract suite own an adapter's failure policy.
Move that configuration into
fixtures/real_model_target_retries.py. Adapters now supply a scopedtenacity.Retryingpolicy throughretrying_model_target_requests. Shared helpers send requests once by default and retain the GET-only guard. Nested scopes restore the preceding policy, including after exceptions. The real adapter installs the same criteria, retry limit, delays, and final-outcome handling as before.The existing retry tests use a copy of the real policy with
wait_none(), removing thetime.sleepmonkeypatch. Two additional tests check installation through the public real Model Target setup fixture and restoration after a nested consumer policy raises. These checks use controlled send callbacks without account access or network calls.Part of #3738 and #3737. This leaves the remaining shared-suite decoupling work open.
Validation:
Docker and live-service validation remain with hosted CI.
Hosted CI is currently blocked by live Vuforia HTTP 429 responses carrying
x-envoy-ratelimited: true. The changed retry-policy tests, mock tests, and lint checks passed. Rerunning failed jobs did not clear the throttle; an isolated retry ofupdate_target/test_width.py, with no other active Test workflows in either VWS repository, also exhausted retries with the same response. Isolated failing job. The live-service checks need another run after the throttle clears.