Repository navigation
Separate shared API fixtures from backend registration - #3759
Merged
Merged
Conversation
This was referenced Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared API setup fixtures imported the repository's backend adapter solely to discard its setup result. Reusable client, target, and endpoint fixtures also lived in the same root configuration that registered that adapter.
Move those reusable fixtures into the explicit
tests.mock_vws.fixtures.api_contractpytest plugin and leave adapter registration in the repository's rootconftest.py. Remove the adapter imports from all 23 directory setup modules. Their ignored setup results now accept any object, allowing consumer adapters to returnNoneor their own setup value.Part of #3738.
Validation:
Noneand a consumer-defined object. Flask and the repository's backend-adapter module were blocked from import; all 23 shared setup modules imported successfully.git diff --check.