Repository navigation
[HDRP] Fix incorrect light list indexing when TAA is enabled - #5287
Conversation
commented
Aug 3, 2021
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
commented
Aug 3, 2021
I think you might have been tricked by github diff viewer, the change is the prepare light function |
commented
Aug 3, 2021
|
good catch! |
commented
Aug 3, 2021
I have been tricked by my own bad eye sight :D |
commented
Aug 3, 2021
|
For QA: merging, test should be enough |
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1352444/
When indexing into the light list, we need to take into account the jittered projection matrix when TAA is enabled.
Before this PR, some tiles in the planar reflection do not have the correct number of reflection probes and part of the reflection is missing (and flickers because on every frame the error is different based on the TAA jitter):

After this PR, all tiles in the planar reflection have the correct number of reflection probes and the reflection is not flickering:

Testing status
The ticket does not include a repro scene, so I've built a very simple scene as you see above.
After this PR, the reflection does not flicker.
Note: I have not tested XR, which might be affected by this PR.