Repository navigation
[HDRP] Fix update order in Graphics Compositor causing jumpy camera updates - #5235
Merged
Merged
Conversation
commented
Jul 27, 2021
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
JMargevics
approved these changes
Jul 27, 2021
adrien-de-tocqueville
approved these changes
Jul 27, 2021
sebastienlagarde
approved these changes
Jul 28, 2021
ghost
marked this pull request as ready for review
July 28, 2021 10:58
ghost
deleted the
HDRP/compositor_update_order
branch
July 28, 2021 10:58
ghost
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1345566/
If a user script changed the state of a camera, then the compositor could see the change with one-frame delay because the compositor's Update() could be called after the user's script Update().
The solution is rather simple, I have moved the compositor's update functionality in LateUpdate.
Testing status