Repository navigation
Fix volumetric fog in planar reflections - #4736
Merged
Merged
Conversation
added 2 commits
June 1, 2021 13:41
sebastienlagarde
approved these changes
Jun 7, 2021
ghost
marked this pull request as ready for review
June 7, 2021 19:41
ghost
deleted the
HDRP/fix-volumetric-fog-in-planar
branch
June 7, 2021 22:14
ghost
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1322845/
The issue was due to the Depth Buffer optimization relying on good linear depth being avaialble, that was not the case with Planar reflections due to the oblique projection.
This PR fixes it as it calculates the linear depth the hard way.
What did I test: the repo scene, can see here
Before
After
