Skip to content

Fix issue with Uber Post process shader when alpha is enabled #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienlagarde merged 3 commits into from
May 12, 2020
Merged

Fix issue with Uber Post process shader when alpha is enabled #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9880f1a
Fix issue with alpha being over 1 hence, leading to the final color b…
FrancescoC-unity May 12, 2020
04f445e
Changelog
FrancescoC-unity May 12, 2020
3a9fe8e
Merge branch 'HDRP/staging' into HDRP/issue-with-pp-alpha
sebastienlagarde May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed issue with reflection probes in realtime time mode with OnEnable baking having wrong lighting with sky set to dynamic (case 1238047).
- Fixed transparent motion vectors not working when in MSAA.
- Fix error when removing DecalProjector from component contextual menu (case 1243960)
- Fixed issue with post process when running in RGBA16 and an object with additive blending is in the scene.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/PostProcessing/Shaders/UberPost.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ void Uber(uint3 dispatchThreadId : SV_DispatchThreadID)
// Alpha mask
#ifdef ENABLE_ALPHA
// Post processing is not applied on pixels with zero alpha
color.xyz = lerp(inputColor.xyz, color.xyz, inputColor.a);
// Saturate is necessary to avoid issues when additive blending pushes the alpha over 1.
color.xyz = lerp(inputColor.xyz, color.xyz, saturate(inputColor.a));
#endif

// Done
Expand Down