Repository navigation
Fix bench_diskless type checking with mypy 2 - #1501
Merged
Merged
Conversation
…no-redef) `for format in [...]` at line 43 defines `format` as str; the later annotated assignment `format: Literal[\"NETCDF3_CLASSIC\"] = ...` is a re-annotation that mypy >= 2.0.0 rejects ([no-redef]), and the lost annotation then makes the `write_netcdf(format=format)` call fail [arg-type]. This keeps the Literal annotation the call needs but gives the second variable its own name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
|
Collaborator
|
thanks for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mypy 2 rejects the
formatannotation in the diskless-read benchmark because the earlier loop already defines that name. Rename the second variable tofmtand update its three uses, retaining theLiteral["NETCDF3_CLASSIC"]annotation required bywrite_netcdf.Fixes #1498.
Validation:
mypy --no-incremental examplespasses all 14 files andmypy --no-incremental testpasses all 57 files using the repository's type stubs on Python 3.14.52a6a411), including Stubtest.