Repository navigation
Fix the ordering of initializing lut due to change in mpl version - #849
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cvanelteren
marked this pull request as ready for review
October 19, 2026 22:09
Collaborator
Author
|
Ah nvm sorry for the ping @munechika-koyo this is not fixed yet. For example this is wrong |
cvanelteren
marked this pull request as draft
October 19, 2026 23:38
Collaborator
Author
ok it's looking good again
|
cvanelteren
marked this pull request as ready for review
October 19, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #848
Fixes as regression in UltraPlot due to major version change in mpl. MPL internally refactorered the initializion of colormaps such that
set_extremesno longer updates the lut. We have set initialized too early, then updating the lut. This PR fixes it by moving that logic up, fixing the situation in both 3.11 and before.