Skip to content

Edgefix off by default - #147

Closed
cvanelteren wants to merge 2 commits into
Ultraplot:mainfrom
cvanelteren:edgefix-off-by-default
Closed

cvanelteren wants to merge 2 commits into
Ultraplot:mainfrom
cvanelteren:edgefix-off-by-default

Conversation

@cvanelteren

Copy link
Copy Markdown
Collaborator

Description

Pcolormesh and pcolor now include functionality to mitigate visual artifacts (such as white lines between color cells) that are generated by some PDF readers when saving plots as vector graphics files. This issue has been a long-standing problem when creating publication-quality vector graphics of color mesh plots. This issue was raised in #136.

What this changes

Sets the rc param from True to false to mittiage annoyances in EDA.
The functionality otherwise remains unchanged.

@cvanelteren
cvanelteren requested a review from Copilot April 7, 2025 07:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

ultraplot/axes/base.py:24

  • [nitpick] The import of get_backend appears to be unused in this file. If it is not used elsewhere, please consider removing it to avoid unnecessary dependencies.
from matplotlib import get_backend

@codecov

codecov Bot commented Apr 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@cvanelteren

Copy link
Copy Markdown
Collaborator Author

Actually I changed my mind. The default output is pdf for UltraPlot and with testing locally I already ran into issues where the pdf produces artifacts.

@cvanelteren cvanelteren closed this Apr 7, 2025
@cvanelteren
cvanelteren deleted the edgefix-off-by-default branch April 7, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants