Skip to content

Fix inline integration setup guidance - #1864

Open
superdav42 wants to merge 1 commit into
mainfrom
feature/auto-20260918-180205
Open

superdav42 wants to merge 1 commit into
mainfrom
feature/auto-20260918-180205

Conversation

@superdav42

@superdav42 superdav42 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • present provider-specific setup guidance alongside integration configuration fields
  • send retired step=instructions URLs to the combined configuration step
  • clarify the shared configuration heading and improve checklist spacing

Testing

  • vendor/bin/phpunit --filter Hosting_Integration_Wizard_Admin_Page_Test (51 tests, 75 assertions)
  • vendor/bin/phpcs inc/admin-pages/class-hosting-integration-wizard-admin-page.php views/wizards/host-integrations/configuration.php
  • vendor/bin/phpstan analyse inc/admin-pages/class-hosting-integration-wizard-admin-page.php
  • pre-commit hook passed

Coordination

Companion Domain Seller change: https://github.com/Ultimate-Multisite/ultimate-multisite-domain-seller/pull/329


aidevops.sh v3.32.317 plugin for OpenCode v1.18.31 with gpt-5.6-sol spent 1h 9m and 647,277 tokens on this with the user in an interactive session.

Summary by CodeRabbit

  • Bug Fixes

    • Links to removed integration instruction steps now open the configuration step instead of leading to an unavailable screen.
  • User Interface

    • Updated the configuration page heading and introductory guidance for greater clarity.
    • Increased spacing between configuration steps to improve readability.

@superdav42 superdav42 added the origin:interactive Created by interactive user session label Sep 19, 2026
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bfec2b71-2f4d-45be-bf51-2782f971787d

📥 Commits

Reviewing files that changed from the base of the PR and between 3cb9d43 and f53fff3.

📒 Files selected for processing (3)
  • inc/admin-pages/class-hosting-integration-wizard-admin-page.php
  • tests/WP_Ultimo/Admin_Pages/Hosting_Integration_Wizard_Admin_Page_Test.php
  • views/wizards/host-integrations/configuration.php

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The hosting integration wizard now maps obsolete instruction-step requests to the configuration section when needed. The configuration view also has updated text and increased spacing between steps. A test covers the section mapping.

Changes

Hosting integration wizard

Layer / File(s) Summary
Removed instruction-step routing
inc/admin-pages/class-hosting-integration-wizard-admin-page.php, tests/WP_Ultimo/Admin_Pages/Hosting_Integration_Wizard_Admin_Page_Test.php
get_current_section() maps instructions to config when the integration has no instructions section. The test verifies this behavior.
Configuration page presentation
views/wizards/host-integrations/configuration.php
The configuration heading and introductory paragraph use new text. The ordered list adds wu-space-y-3 spacing.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding inline integration setup guidance and related configuration-step handling.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:interactive Created by interactive user session

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant