Conversation
Scrapers previously called panic/log.Fatal/log.Panic on failure, which crashed the whole process and threw away progress on long-running scrapes (astra, coursebook). Scraper functions and the helpers they call (RefreshToken, RefreshAstraToken, GetCoursePrefixes, ExtractTextAndHref) now return errors instead, propagated up through main, which exits non-zero on failure. Fixes #192 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CI's staticcheck step (ST1005) requires error strings to be lowercase and not end with punctuation. Fixes the 6 flagged spots in astra.go and coursebook.go from the panic-to-error refactor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192
Scrapers previously called panic()/log.Fatal()/log.Panic() on failure, which crashed the whole process and threw away progress on long-running scrapes (astra.go's full-year date sweep, coursebook.go's per-prefix walk). Each Scrape* function and the helpers they call now return an error instead, propagated up through main, which exits non-zero on failure without a panic.
Includes and builds on commits from @ThatRell (budgets.go, cometCalendar.go, coursebook.go) already pushed to this branch, rebased together with the rest of the scrapers/utils changes.
Test plan
go build ./...andgo vet ./...pass