Use ISO 8601 format for log filenames - #165
Open
SuchDominion wants to merge 4 commits into
Open
SuchDominion wants to merge 4 commits into
SuchDominion wants to merge 4 commits into
Conversation
Log files are now named YYYY-MM-DDTHH-MM-SS.log with zero-padded fields so they sort lexicographically by creation time.
Contributor
|
Not sure if we need the padding for the year because it's already 4 digits and the padding wouldn't do anything for year 10000 onward. Not a big deal though, everything else looks good. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YYYY-MM-DDTHH-MM-SS.logTest plan
go build ./...passes2026-04-16T22-42-15.logis created under./logs/