This repository was archived by the owner on Jun 29, 2026. It is now read-only.
fix: make kind non-enumerable - #82
Merged
Merged
Conversation
MisterCommand
requested review from
Copilot and
flandia
and removed request for
Copilot
February 25, 2026 01:04
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the custom UnionOneOf TypeBox schema helper so its internal ~kind marker matches TypeBox v1’s non-enumerable behavior, avoiding Ajv strict-mode schema rejection.
Changes:
- Make
~kindnon-enumerable on theUnionOneOfschema object viaObject.defineProperty. - Minor modification to the file’s header attribution line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeBox v1 has a setting enumerableKind (default false) that makes ~kind non-enumerable on all standard types via Memory.Create(). However, the custom UnionOneOf function sets "~kind" directly on the object literal, making it enumerable — so Ajv sees it and rejects it in strict mode.
The fix is to make ~kind non-enumerable in UnionOneOf, matching how TypeBox v1 handles it internally.
The fix makes ~kind a non-enumerable property on the UnionOneOf schema object, matching how TypeBox v1 handles ~kind internally via Memory.Create(). Previously it was set as a regular enumerable property via object spread ({ ...options, "~kind": "UnionOneOf", oneOf }), which meant Ajv would see it during schema compilation and reject it in strict mode.