Repository navigation
Bring geoprocessor source and tests into cumulus-api - #798
Open
oskarhurst wants to merge 2 commits into
Open
oskarhurst wants to merge 2 commits into
oskarhurst wants to merge 2 commits into
Conversation
Source: https://github.com/USACE/cumulus-geoproc/tree/0a25999b81f69f2922e49b68e323b960fc3f67d3. Preserve the package, license, test fixtures, developer scripts, and documentation configuration without changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The geoprocess worker currently downloads the processor package from
USACE/cumulus-geoproc@mainduring its Docker build. Processor changes therefore require a separate repository push and can change an image without a corresponding Cumulus API commit.This PR brings processor development and builds into this repository. Editing
async_geoprocess/geoproc/src/cumulus_geoproc/processors/and rebuildinggeoprocessnow uses that exact local source.Changes
ADDwith a local packageCOPY. Remove the obsolete processor Git-ref build argument from Compose and image workflows.Reference grids remain in
USACE/cumulus-geoproc-test-data, using the same2025-11-04release as the upstream test suite. Only the test image downloads that archive and installs development dependencies. Existing generated documentation stays indocs/async_geoprocess; the upstream generated test report is not imported.Validation
docker build -t cumulus-geoproc-migration-review async_geoprocess— passed.docker compose -f async_geoprocess/docker-compose.tests.yml build geoproc— passed.docker compose -f async_geoprocess/docker-compose.tests.yml run --rm geoproc— 16 passed in 66 seconds, including reference-grid conversions and COG validation. Three warnings were emitted: one NumPy binary-size warning and two Python warnings aboutcontinueinsidefinallyin imported processors.This validates processor execution with reference data, not a live SQS-to-API end-to-end run.
The original
cumulus-geoprocrepository is not archived or deleted by this PR. After merge, processor changes should be submitted here.