Skip to content

fix: Custom inline content crash - #788

Merged
matthewlipski merged 1 commit into
TypeCellOS:mainfrom
conr:cb/fix-custom-inline-content
Jun 6, 2024
Merged

fix: Custom inline content crash#788
matthewlipski merged 1 commit into
TypeCellOS:mainfrom
conr:cb/fix-custom-inline-content

Conversation

@conr

@conr conr commented May 31, 2024

Copy link
Copy Markdown
Contributor

Fixes #750

Before

image

After

image

@vercel

vercel Bot commented May 31, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 3, 2024 11:30am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 3, 2024 11:30am

@vercel

vercel Bot commented May 31, 2024

Copy link
Copy Markdown

@conr is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@conr
conr marked this pull request as ready for review May 31, 2024 12:15
@YousefED

YousefED commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

Thanks @conr. This looks like a good temporary fix, but I still want to figure out the root cause (why is contentComponent undefined). If the CI passes I'd be happy to merge this regardless

@conr

conr commented Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

@YousefED That's very fair!

Looks like CI is passing now

@Dhruvagwal Dhruvagwal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to be woking for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'renderToElement')

4 participants