clean getitems - #579
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…or' into mentions-suggestions-getitems
YousefED
changed the base branch from
mentions-suggestions
to
ui-component-creation-refactor
February 15, 2024 06:31
matthewlipski
left a comment
matthewlipski
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Minor comments
…ns-getitems # Conflicts: # packages/react/src/components/SuggestionMenu/DefaultPositionedSuggestionMenu.tsx # packages/react/src/index.ts
YousefED
changed the base branch from
ui-component-creation-refactor
to
mentions-suggestions
February 15, 2024 14:16
58 tasks
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, any type T can be returned from
getItems, as long as it's also expected by the element passed assuggestionMenuComponent. When using the default componentMantineSuggestionMenu, we expectDefaultSuggestionItemas items.Also:
TODO:
slashMenuItemsAPI working? (not too much effort I think)